update services articles in v14 #5987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alina-tincas
commented
Mar 27, 2024
14/umbraco-cms/reference/management/services/retrieving-content-types.md
Outdated
Show resolved
Hide resolved
eshanrnh
requested changes
Mar 27, 2024
Contributor
eshanrnh
left a comment
eshanrnh
left a comment
There was a problem hiding this comment.
Looks good, @alina-tincas 🙌 I just have a few suggestions.
| description: List of services references, how to use them and some examples. | ||
| --- | ||
|
|
||
| # Services References |
Contributor
There was a problem hiding this comment.
Not sure if its randomly listed or as per preference but it might make sense to list the services alphabetically.
14/umbraco-cms/reference/management/services/create-a-new-user.md
Outdated
Show resolved
Hide resolved
14/umbraco-cms/reference/management/services/create-a-new-user.md
Outdated
Show resolved
Hide resolved
14/umbraco-cms/reference/management/services/relationservice.md
Outdated
Show resolved
Hide resolved
14/umbraco-cms/reference/management/services/retrieving-content-types.md
Outdated
Show resolved
Hide resolved
14/umbraco-cms/reference/management/services/retrieving-languages.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
…t-types.md Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
…ges.md Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
alina-tincas
commented
Mar 27, 2024
Contributor
Author
|
Thank you for the suggestions @eshanrnh 🙌 I have make the necessary changes, can you please check again? 😊 |
alina-tincas
commented
Mar 27, 2024
14/umbraco-cms/reference/management/services/create-a-new-user.md
Outdated
Show resolved
Hide resolved
eshanrnh
approved these changes
Mar 27, 2024
Contributor
eshanrnh
left a comment
eshanrnh
left a comment
There was a problem hiding this comment.
Looks good to me, @alina-tincas 🙌#h5YR
alina-tincas
commented
Mar 27, 2024
14/umbraco-cms/reference/management/services/retrieving-content-types.md
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thank you for the review @eshanrnh 🙌 As all is good, am merging this in 😊 |
alina-tincas
added a commit
that referenced
this pull request
Apr 4, 2024
alina-tincas
added a commit
that referenced
this pull request
Apr 4, 2024
fix broken links related to removed articles from #5987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What did you add/update/change?
updated services articles in v14
Most articles use same example and a lot more information is found on the API docs. So it does not make sense to keep all those articles.
I have therefore added a link to API docs on the readme file to all services and kept only the articles that have some examples (moved those to the root as well to keep them in one place)
Type of suggestion
Product & version (if relevant)
cms v14
Deadline (if relevant)
When should the content be published?