Skip to content

V14 RC: Two-Factor Authentication code examples update #6085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2024
Merged

V14 RC: Two-Factor Authentication code examples update #6085

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
731ef92
docs: add some additional error handling to the examples
iOvergaard May 8, 2024
f0d67f1
docs: remove reference to Umbraco.Extensions
iOvergaard May 8, 2024
99593e1
Merge branch 'main' of github.com:umbraco/UmbracoDocs into v14/docs/2fa
iOvergaard May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions 14/umbraco-cms/reference/security/two-factor-authentication.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ Now we need to register the `UmbracoAppAuthenticator` implementation. This can b
using Umbraco.Cms.Core.Composing;
using Umbraco.Cms.Core.DependencyInjection;
using Umbraco.Cms.Core.Security;
using Umbraco.Extensions;

namespace My.Website;

Expand Down Expand Up @@ -211,7 +210,6 @@ using Google.Authenticator;
using Umbraco.Cms.Core.Models.Membership;
using Umbraco.Cms.Core.Security;
using Umbraco.Cms.Core.Services;
using Umbraco.Extensions;

namespace My.Website;

Expand Down Expand Up @@ -309,7 +307,7 @@ public class UmbracoAppAuthenticatorComposer : IComposer
{
var identityBuilder = new BackOfficeIdentityBuilder(builder.Services);

identityBuilder.AddTwoFactorProvider<UmbracoUserAppAuthenticator>(UmbracoUserAppAuthenticator.Name);
identityBuilder.AddTwoFactorProvider<UmbracoUserAppAuthenticator>(UmbracoUserAppAuthenticator.Name);
}
}
```
Expand Down Expand Up @@ -682,13 +680,15 @@ export default class My2faViewElement extends UmbLitElement {
async onSubmit(evt, provider) {
evt.preventDefault();

this.codeField.error = false;
this.codeField.setCustomValidity('');
this.errorMessage = '';

/**
* @type {HTMLFormElement}
*/
const form = evt.target;

this.codeField.error = false;

const isValid = form.checkValidity();
if (!isValid) {
return;
Expand Down Expand Up @@ -725,7 +725,7 @@ export default class My2faViewElement extends UmbLitElement {
renderProvider(provider) {
return html`
<uui-form>
<form method="post" @submit=${(e) => this.onSubmit(e, provider)}>
<form method="post" @submit=${(e) => this.onSubmit(e, provider)} novalidate>
<h3>${provider}</h3>
<p>You are about to sign-in with ${provider}.</p>
<uui-form-layout-item>
Expand Down