Skip to content

Conversation

@Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented May 24, 2024

Description

Added documentation about how to document your controllers in swagger

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

V14

Deadline (if relevant)

Release of v14 🚀

@Zeegaan Zeegaan changed the title Custom swagger doc v14: Custom swagger doc May 24, 2024
@Zeegaan Zeegaan changed the title v14: Custom swagger doc V14: Custom swagger doc May 24, 2024
@eshanrnh
Copy link
Contributor

Thanks, @Zeegaan for the PR. We will takw a look and merge it in for the v14 release 💪

@alina-tincas
Copy link
Contributor

Hi @Zeegaan before we review this PR, can you please add this new article to summary as well? Also, it seems you are adding the "documenting your controllers" in this PR as well, even though there is another PR (#6106) for this? 🙈

@Zeegaan
Copy link
Member Author

Zeegaan commented May 27, 2024

@alina-tincas Yep, we need to move this around, so will do when i move it 😁
And yea, I expected #6106 to be merged already, so I have the changes on this branch too, woops 🙈

@alina-tincas
Copy link
Contributor

All righty, then in this case I think @jonat123 can review this PR and close the other one to not cause merge conflicts between PRs. @jonat123 what do you think? 😊

Copy link
Contributor

@jonat123 jonat123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zeegaan Looks good to me :-)

they only needs to be added to the summary file then it can be merged :D

@Zeegaan Zeegaan changed the title V14: Custom swagger doc V14: Documenting your controllers May 27, 2024
@Zeegaan
Copy link
Member Author

Zeegaan commented May 27, 2024

@jonat123 Should be ready now, it is now moved under the tutorial section instead 😁

@kjac
Copy link
Contributor

kjac commented May 27, 2024

This looks great @Zeegaan ❤️

@jonat123 jonat123 merged commit a46f547 into umbraco:main May 28, 2024
@Zeegaan Zeegaan deleted the custom-swagger-doc branch May 28, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants