-
Notifications
You must be signed in to change notification settings - Fork 811
Update ui-config-files.md #6302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If you are hosting your site in Umbraco Cloud and using Visual Studio then you will have to make sure that the file/files (or parent folder of the files) you include will be configured in certain way in the .Web project configuration file. This is to ensure that the Umbraco Cloud site will be able to use the file/files.
|
Not sure why the ReviewDog service failed its checks. 🤔 |
|
Nvm the ReviewDog did tell me why it did not approve. |
Making the sentence shorter.
|
Thanks for the PR, @peaxe 🙌 We will review it as soon as we can 💪 |
|
I'm not entirely sure why this is necessary. There isn't anything in the default cloud Can you explain more about your specific project structure? And what issue you were seeing if this settings wasn't present? |
|
Thank you for taking time to review this. Let me include the question to Umbraco Support and their answer that lead me to think that perhaps it is a good thing to include this information in the docs to cater the scenario when working with an Umbraco Cloud project in Visual Studio and adding json config files under App_Plugins. The question I sent to Umbraco Support
The answer I got from Umbraco Support
|
|
Hmm, based upon the comments in the linked issue, wouldn't it just make more sense that the If this is the case, then I'd be tempted to just update one line in the docs under the heading Assigning a UI Config File to a Store change the path where configs are looked for from |
|
Perhaps I'm comparing apples and pears. Then again I might have misunderstood the advice from that comment. 😊 If the action you suggest is considered as best practice, then sure that advice sounds good and I'm glad if the docs contains that advice. |
|
Thanks @peaxe I get where Kevin is coming from here, and if I were developing an actual app plugin, then yea, I'd probably follow his advice, but given you aren't creating a plugin, you simple have a static config file that you want to make available, the simplest thing here would be for it to live directly in the |
|
Thank you @mattbrailsford for having the patience to sort this one out with me. And making me understand things better. I totally agree with you that the advice can be simplified into: put the config files in the folder of: |
|
No problem at all @peaxe I'm sorry this has been as big a source of confusion as it has for you. I'm just thankful for your submission so we can improve the docs to try and make sure other don't face the same 🙏 |
Update thanks to the feedback from @mattbrailsford
|
There: I (hopefully 😸 ) made the update you suggested @mattbrailsford |
|
Yup, PR looks good to me. Thanks again for the PR, it's very much appreciated. And the best of luck with the rest of the project. |
|
Thanks for the helping reviewing here @mattbrailsford ! 💪 And thanks again @peaxe , for help keeping our docs up to speed 😄 |




If you are hosting your site in Umbraco Cloud and using Visual Studio then you will have to make sure that the file/files (or parent folder of the files) you include will be configured in certain way in the .Web project configuration file. This is to ensure that the Umbraco Cloud site will be able to use the file/files.
Description
What did you add/update/change?
Type of suggestion
Product & version (if relevant)
Umbraco 13 but possibly from Umbraco 10 to Umbraco 14
Deadline (if relevant)
When should the content be published?