Skip to content

Conversation

@naepalm
Copy link
Contributor

@naepalm naepalm commented Oct 3, 2024

Changed Plugins and ValidElements to display all items for easier copy-paste

Description

Updated the RTE configuration documentation to include the entire settings for plugins and valid elements. Because you have to copy the valid elements to append items to them, to get the full list you currently have to dig into the source code. I think it's much more user friendly to be able to copy-paste right from the documentation, even though it makes the list very long.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

v10 & v13

Deadline (if relevant)

As soon as possible :)

Changed Plugins and ValidElements to display all items for easier copy-paste
@sofietoft
Copy link
Contributor

Thanks for the PR @naepalm ! 🥳

I'll make sure we review this as soon as possible.

@jonat123
Copy link
Contributor

jonat123 commented Oct 8, 2024

@naepalm THe only thing about this is that the text above the code example should be changed if we display all the elements:
image

Could I get you to change it? 😊

@naepalm
Copy link
Contributor Author

naepalm commented Oct 8, 2024

Hi @jonat123! I didn't change it because there's actually a spot further down where I left the text truncated - I don't think it's as important for the entire commands list to be copied in since it's easier to change with the way it's set up.

But maybe we want to modify that too? (It IS a huge list...)

image

@jonat123
Copy link
Contributor

jonat123 commented Oct 9, 2024

Ah okay, I missed that 🙈

I think it is fine to just let it be then 😄

@sofietoft sofietoft merged commit 7e94e0c into umbraco:main Oct 21, 2024
@umbrabot
Copy link

umbrabot commented Dec 4, 2024

Hi there @naepalm!

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!
This year's swag is a custom designed notebook and custom Umbraco Hacktoberfest sticker:

image

As an alternative choice, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 25nd, 2024, 23:59:00 UTC.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few weeks/months, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco teams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants