-
Notifications
You must be signed in to change notification settings - Fork 810
Document Deploy legacy property type migrators, import and migration flow and clarify grid editor configuration #6533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sofietoft
merged 9 commits into
umbraco:main
from
ronaldbarendse:deploy/import-operation-order
Oct 16, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5a2800c
Update legacy import composer example (add legacy property type migra…
ronaldbarendse f0e6620
Add 'Import and migration flow' paragraph
ronaldbarendse 0ad2685
Add note about providing custom grid editor configuration
ronaldbarendse 266d18e
Add note about custom DTGE grid editor configuration
ronaldbarendse 049bcbd
Apply suggestions from code review
ronaldbarendse 37ab97d
Apply suggestions to 14
sofietoft bb4be99
Apply suggestions to 14
sofietoft 8d473d4
Fix vale error
sofietoft 898c98a
Minor changes to trigger checks
sofietoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before I start working on this list, I need to know: Is it steps that the user needs to go through, or is it an explanation of what happens during a migration/import? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an explanation of the things that happen and should give users a better understanding of the (order of) operations.
We also hadn't documented the notifications yet or the fact a default
ValidateArtifactImportDependenciesNotificationHandleris added by Deploy. We might want to add a separate section about notifications though, as we also have notifications that happen during export (ArtifactExportingNotificationandArtifactExportedNotification).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I wont touch the list then 💪
It would be great to have a new section about notifications.
Let me know what you need from us to set this up!