Skip to content

Conversation

@ronaldbarendse
Copy link
Contributor

@ronaldbarendse ronaldbarendse commented Oct 7, 2024

Description

Deploy Contrib 13.3 and 14.2 added legacy property type migrators (besides the artifact migrators, see PR umbraco/Umbraco.Deploy.Contrib#71), which requires extra setup code to correctly migrate all values from version 7. I've currently only amended the documented composer with the required code and an inline comment, as I don't think we need to add a separate mention about this...

While preparing my talk for DF24, I also noticed we currently don't have any documentation about the import and migration flow, including the notifications that are published. I've added a new paragraph/section to list out all steps involved in this operation.

Finally, I've added notes about providing custom grid editor configurations when migrating the legacy Grid editor to the Block Grid editor, resolving umbraco/Umbraco.Deploy.Issues#236.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Deploy 13 & 14
Deploy Contrib 13.3 and 14.2

Deadline (if relevant)

This applies to already released Deploy and Deploy Contrib versions, so can be merged ASAP.

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some suggestions and comments.
The same suggestions applies to version 14 🙌

### Import and migration flow

When an import is started, the following happens:
1. Artifact signatures are read from the import provider (using `IArtifactImportProvider.GetArtifactSignatures()`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I start working on this list, I need to know: Is it steps that the user needs to go through, or is it an explanation of what happens during a migration/import? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an explanation of the things that happen and should give users a better understanding of the (order of) operations.

We also hadn't documented the notifications yet or the fact a default ValidateArtifactImportDependenciesNotificationHandler is added by Deploy. We might want to add a separate section about notifications though, as we also have notifications that happen during export (ArtifactExportingNotification and ArtifactExportedNotification).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I wont touch the list then 💪

It would be great to have a new section about notifications.
Let me know what you need from us to set this up!

@sofietoft sofietoft merged commit 85b23da into umbraco:main Oct 16, 2024
33 of 34 checks passed
@ronaldbarendse ronaldbarendse deleted the deploy/import-operation-order branch October 16, 2024 08:36
sofietoft added a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants