feat: Send data using delete#45
Merged
Merged
Conversation
Contributor
|
赞，但是能加一个单测吗？@xchunzhao |
Contributor
Author
|
@clock157 加了。 |
yesmeck
reviewed
Apr 18, 2019
| import request, { extend } from "../src/index"; | ||
| import { MapCache } from "../src/utils"; | ||
| const debug = require("debug")("afx-request:test"); | ||
| import createTestServer from 'create-test-server'; |
Contributor
Author
There was a problem hiding this comment.
我看看。应该是prettier做的
Contributor
Author
There was a problem hiding this comment.
这个不应该改
prettier配置的规则是单引号。
Contributor
There was a problem hiding this comment.
检查发现 package.json 的 lintStage 一直未生效，因为参数错误。我合了，新拉个分支使用 umi-lint 修复 prettier 的问题。
"prettier --write --singleQuote=true --trailingComma=all --printWidth=120"
clock157
approved these changes
Apr 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
当method=delete时候，删除多条记录body没有包装。#44