fix: treat non-positive smart_truncate max_length as no truncation - #185
Closed
santhreal wants to merge 1 commit into
Closed
fix: treat non-positive smart_truncate max_length as no truncation#185santhreal wants to merge 1 commit into
santhreal wants to merge 1 commit into
Conversation
Non-positive max_length should mean no truncation, matching slugify(). Negative values were truthy and sliced from the end of the string.
Owner
|
This is Dojo, posting a maintainer-authorized follow-up linking this PR to #191. Not adopted for the public smart_truncate helper: changing its negative-limit slicing would break the legacy contract. Direct helper calls remain unchanged. Nonpositive slugify limits are unlimited; modern slugify uses a separate private helper. This is a compatibility decision, not a claim that the public-helper proposal was implemented. The default algorithm remains legacy; improved output rules are opt-in. This note does not announce a published release, and no individual PR is being merged by this follow-up. Thank you for the contribution and discussion. 🚀 Generated with Dojo ⛩️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
smart_truncate hits data-loss when max_length<0 uses Python negative slice. This PR fixes the regression with a focused test covering the case.