fix(docker): preserve single-url crawl failure details - #2117
Open
nightcityblade wants to merge 1 commit into
Open
fix(docker): preserve single-url crawl failure details#2117nightcityblade wants to merge 1 commit into
nightcityblade wants to merge 1 commit into
Conversation
Contributor
Author
|
CI note: the code-related posture-gate and security-offline checks both pass. The only failing job is the Discord notification workflow; its log shows an empty DISCORD_WEBHOOK and exits before exercising this change. This is repository/fork-secret configuration rather than a patch failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2116
Treat unsuccessful crawls from the single-URL
/mdand/llm/{url}handlers as upstream failures (502 Bad Gateway) so the existing exception handler preserveserror_messageinstead of replacing it with an opaque internal-server-error response. The LLM handler now also preserves deliberateHTTPExceptionstatuses.List of files changed and why
deploy/docker/api.py- centralize unsuccessful crawl handling and return a detail-preserving 502 from both single-URL handlers.deploy/docker/tests/test_api_crawl_failures.py- verify the 502 mapping, preserved anti-bot reason, both handler call sites, and LLM exception propagation.How Has This Been Tested?
.venv/bin/python -m pytest deploy/docker/tests/test_api_crawl_failures.py -q(3 passed).venv/bin/python -m pytest deploy/docker/tests/test_security_headers_xss.py::TestErrorSanitization -q(2 passed).venv/bin/python -m ruff check --select E9,F63,F7,F82 deploy/docker/api.py deploy/docker/tests/test_api_crawl_failures.py(passed)Checklist: