feat: add static/ui website folder (from aws-command)#264
feat: add static/ui website folder (from aws-command)#264unclehowell merged 1 commit intogh-pagesfrom
Conversation
Deploying datro2 with
|
| Latest commit: |
0de8da9
|
| Status: | 🚫 Build failed. |
Deploying dcc with
|
| Latest commit: |
0de8da9
|
| Status: | 🚫 Build failed. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
puck | 0de8da9 | Apr 07 2026, 07:40 AM |
Deploying ccan-homepage with
|
| Latest commit: |
0de8da9
|
| Status: | 🚫 Build failed. |
Deploying carfinancecheque with
|
| Latest commit: |
0de8da9
|
| Status: | 🚫 Build failed. |
Deploying financecheque with
|
| Latest commit: |
0de8da9
|
| Status: | 🚫 Build failed. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0de8da9afa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| a&&a.message&&d(a.message+' at '+(a.filename||'?')+':'+(a.lineno||''),'error')}); | ||
| window.addEventListener('unhandledrejection',function(a){a&&a.reason&&d('Unhandled rejection: '+(a.reason.message||String(a.reason)),'error')}); | ||
| var e=console;['error','warn','info','log'].forEach(function(b){var c=e[b]; | ||
| e[b]=function(){for(var a=new Array(arguments.length),d=0;d<a.length;++d)a[d]=arguments[d];var f=a.map(function(b){return'object'==typeof b?JSON.stringify(b).substring(0,200):String(b)}).join(' ');d(f,b);c.apply(e,arguments)}})}catch(a){}})(); |
There was a problem hiding this comment.
The console override declares d as the loop index and then calls d(f, b) in the same scope, so d is a number instead of the logging helper function. On the first console.error/warn/info/log call this throws TypeError: d is not a function, which breaks the capture path and can interrupt subsequent page scripts.
Useful? React with 👍 / 👎.
| </head> | ||
| <body id="body"> | ||
| <body> | ||
| <iframe src="/links-app/" style="width:100%;height:100%;border:none;"></iframe> |
There was a problem hiding this comment.
The Settings lookup now embeds /links-app/, but this commit wires the links app to /links/ elsewhere and does not add any /links-app/ resource in the static bundle. In this state, opening Settings loads a broken iframe target (404) instead of the links UI.
Useful? React with 👍 / 👎.
| if (username === 'signals' && password === 'cirtacito') { | ||
| localStorage.setItem('auth_token', 'cirtacito_logged_in'); |
There was a problem hiding this comment.
This login flow hardcodes the username/password in shipped JavaScript, so anyone can view source and recover valid credentials; combined with the localStorage token gate, access control is trivially bypassed. If this page is meant to protect /paperclip/, it currently provides no real authentication security.
Useful? React with 👍 / 👎.
2 participants
Adds the static/ui folder with 432 files. Generated by the aws-command Hermes endpoint.