Upgrade: Ruby 3.0.6; Rails 6.1.7.6 #969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, we should add this to our Gemfile.
… so safe to remove the dependancy gem in our Gemfile.
…ient js libraries
Fixes issues caused by updating versions of the ember-rails and ember-data-source gems
by running the following:
rails generate ember:install --tag=v1.6.1 --ember
rails generate ember:install --tag=v0.14 --ember-data
...and committing the files the commands place in `vendor/`
…-5-fix-frontend fix: ember was broken, and some assets failed to load
…ken Rails 5.0 belongs_to.
pdl
force-pushed
the
upgrade/rails-6.1.7.6
branch
from
0a10df9 to
cb21368
Compare
The variable @search_params was not set - see https://unep-wcmc.codebasehq.com/projects/species-rails-upgrade/tickets/108
https://unep-wcmc.codebasehq.com/projects/species-rails-upgrade/tickets/117 `scientific_name=` was being called before `name_status` was set, which meant that it always behaved as if `name_status` were the string 'A' during instantiation, because the setter for `name_status` had not yet been called. This meant that new synonyms were losing the genus part of the binomial full name assigned to them, because this is stripped for A-names.
…mview fails https://unep-wcmc.codebasehq.com/projects/species-rails-upgrade/tickets/139 If a user edits names in change_type so that either ADDITION or DELETION is missing, then this function will concatenate NULL while building SQL, leading to a confusing error message.
... so that it's clear when it's all done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade strategy: Keep the same behaviour as possible, not intend to refactor any code unless necessary.
Major Upgrade
New (including but not limited to)
cap-deploy. For capistrano deployahoy_mateyreadme to reconfigure for GDPRrebuild_job_dailycron job in Sidekiq->Cron admin page, so the rebuild task only run on Saturday.Replaced (including but not limited to)
cancanwithcancancantracowithmobilitywheneverwithsidekiq-cron. Make sure remove all cronjob in crontab when deploy to productionprotected_attributeswith build-in strong parameterswebrickwithpuma(for development)factory_girlwithfactory_bot(for testing)Things not being upgrade
secrets.yml. Not migrate to newcredentialswhich was introduced in Rails 5.2jquery_ujs. Not migrate to newrails-ujswhich was introduced in Rails 5.2database_cleaner. The current test setup not working well with build-in transactional test which was introduced in Rails 5.1carrierwave. Not migrate to ActiveStorage which was introduced in Rails 5.2sidekiq-unique-jobsdoesn't work with ActiveJobvendororapp/assets(Thanks @pdl)aws-sdkv2, should upgrade to v3bootstrap-sass2, upgrade will change to v3 css, may not compatibleShould upgrade but can't
wickedwithout breaking test.sass-railsto 6. A JS file in vendor directory, has some special syntax to support old browsers, doesn't work with assets:precompilepaper_trailto latest (https://github.com/paper-trail-gem/paper_trail/blob/master/doc/pt_13_yaml_safe_load.md)sidekiqto latest at it require Redis 6.2+, but our server running Redis 4.0.9active_model_serializers. Newer version has breaking change.Removed (including but not limited to)
clerk. Re-implement ourselvestimecop. Replaced with build-in methods which was introduced in Rails 4.2rails-observer, which removed from Rails core since Rails 4.0. Moved those callbacks back to model/mixin/inherited class, as well as refactoring, move anything not within DB transaction, to after_commit (e.g. cache related; perform async job).Deprecated gem, should find replacement
inherited_resourcesactionpack-action_cachingandactionpack-page_caching, which was removed from Rails core since Rails 4active_model_serializerssusynested_formFurther suggestions
rack-corskaminarimigrate topagy