-
-
Notifications
You must be signed in to change notification settings - Fork 20
chore: update deps #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update deps #118
Conversation
135bd5b to
9e9e1b0
Compare
WalkthroughThis change updates development and runtime dependency versions in three package.json files across different template packages. The affected dependencies include @skiyee/uni-ui, @skiyee/ui-preset, @dcloudio/types, typescript, and vue-tsc. No other configuration, scripts, or exported/public entities were altered. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/core/template/UI/skiyee/package.json (1)
6-6: Keep@skiyee/ui-presetin lock-step with runtime libThe preset normally mirrors the runtime package’s minor version. If 0.0.5 lags behind new breakpoints or colors introduced in 0.2.0, design tokens could desync.
Consider updating both to the same minor stream (e.g., 0.2.x) if available.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
packages/core/template/UI/skiyee/package.json(1 hunks)packages/core/template/base/package.json(1 hunks)packages/core/template/config/typescript/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: stable - x86_64-pc-windows-msvc - node@20
- GitHub Check: stable - x86_64-apple-darwin - node@20
- GitHub Check: stable - i686-pc-windows-msvc - node@20
- GitHub Check: stable - aarch64-pc-windows-msvc - node@20
🔇 Additional comments (3)
packages/core/template/base/package.json (1)
65-65: Confirmed single declaration of@dcloudio/typesI searched all
package.jsonfiles and found only one declaration:
packages/core/template/base/package.json: "@dcloudio/types": "^3.4.19"No other packages or templates reference this dependency, so all consumers are already aligned on
3.4.19. No further action needed.packages/core/template/config/typescript/package.json (1)
8-9: It looks like the filter path in the dry-run command doesn’t match any package in the repo—there is nopackages/core/template/basefolder. To verify that TS 5.9 & vue-tsc 3.0.5 compile correctly, please run a dry build against the actual template project. For example, if the config package is atpackages/core/template/config/typescript, try:pnpm --filter ./packages/core/template/config/typescript exec tsc -p packages/core/template/config/typescript/tsconfig.json --noEmitIf that succeeds without errors, you can proceed. Otherwise, investigate any downstream plugins (e.g. unplugin-vue-macros, custom esbuild plugins) for TS 5.9 compatibility.
packages/core/template/UI/skiyee/package.json (1)
3-3:@skiyee/uni-ui0.2.x may contain breaking style tokens0.2.0 changelog mentions revamped component props & Tailwind token names. Verify sample pages still render and that any tree-shaken imports match the new entry points.
Update dependencies
Summary by CodeRabbit