Skip to content

Conversation

@FliPPeDround
Copy link
Member

@FliPPeDround FliPPeDround commented Sep 8, 2025

Update dependencies

Summary by CodeRabbit

  • Chores
    • Dependency maintenance: upgraded UI preset to 0.0.8 for improved compatibility with current tooling.
    • Updated ESLint to 9.35.0 to incorporate the latest linting rules and fixes.
    • Bumped Node type definitions to 24.3.1 for up-to-date TypeScript support.
    • No user-facing changes; updates affect development, build, and lint workflows only.

@coderabbitai
Copy link

coderabbitai bot commented Sep 8, 2025

Walkthrough

Bumps devDependency versions in three template package.json files: @skiyee/ui-preset (^0.0.7→^0.0.8), eslint (^9.34.0→^9.35.0), and @types/node (^24.3.0→^24.3.1). No other fields changed and no code or API surface modifications are introduced.

Changes

Cohort / File(s) Summary
UI preset bump
packages/core/template/UI/skiyee/package.json
Update devDependency @skiyee/ui-preset from ^0.0.7 to ^0.0.8.
ESLint config bump
packages/core/template/config/lint/package.json
Update devDependency eslint from ^9.34.0 to ^9.35.0.
TypeScript types bump
packages/core/template/config/typescript/package.json
Update devDependency @types/node from ^24.3.0 to ^24.3.1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

size/S

Poem

Hop hop! I tweak the versions tight,
Little bumps to keep things right.
ESLint hums, TypeScript nods,
UI preset winks at mods.
Carrots logged, no code to fear—
Ship it clean, the path is clear! 🥕✨

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/update-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
packages/core/template/config/typescript/package.json (1)

6-10: Align @types/node in template to match root Node LTS
packages/core/template/config/typescript/package.json: change "@types/node": "^24.3.1""@types/node": "^18.19.50" to match the root devDependency and reduce API drift.

packages/core/template/UI/skiyee/package.json (1)

6-8: Approve preset bump; evaluate template version strategy

  • Semver ^0.0.8 only pulls patch updates (effectively ~0.0.8)
  • All templates consistently declare packageManager: "pnpm@9.9.0"

For reproducible scaffolds, pin exact versions; keep the caret if you prefer automatic patch upgrades.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db4d80a and dcdf049.

📒 Files selected for processing (3)
  • packages/core/template/UI/skiyee/package.json (1 hunks)
  • packages/core/template/config/lint/package.json (1 hunks)
  • packages/core/template/config/typescript/package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
  • GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
  • GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
  • GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
  • GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
  • GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
  • GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
  • GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
  • GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
  • GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
  • GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
  • GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
  • GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
  • GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
  • GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
  • GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
  • GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
  • GitHub Check: stable - aarch64-pc-windows-msvc - node@20
  • GitHub Check: stable - i686-pc-windows-msvc - node@20
  • GitHub Check: stable - x86_64-pc-windows-msvc - node@20

Comment on lines 7 to 9
"@uni-helper/eslint-config": "^0.5.0",
"eslint": "^9.34.0"
"eslint": "^9.35.0"
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

ESLint bump looks fine; verify peer/engine compatibility.

Since you’re already on ESLint 9.x, 9.35.0 should be safe. Please double-check Node engine constraints and the eslint-config’s peerDeps to avoid hidden CI breaks.

Run:


🏁 Script executed:

#!/bin/bash
set -euo pipefail

# ESLint engine requirements
npm view eslint@9.35.0 engines

# Peer deps of your config
npm view @uni-helper/eslint-config@latest peerDependencies

# Inventory any eslint-* plugins in repo (to spot potential 9.x incompatibilities)
fd -a package.json | xargs -I{} jq -r '.devDependencies // {} | keys[]' {} | rg -n '^eslint-'

Length of output: 7522


🏁 Script executed:

#!/bin/bash
set -euo pipefail

# 1. Check Node engine constraints in the root package.json
if [ -f package.json ]; then
  echo "Root package.json engines:"
  jq '.engines // {}' package.json
else
  echo "No root package.json found"
fi

# 2. List all Node engine constraints across every package.json
echo
echo "All package.json Node engine constraints:"
rg -nP '"node"\s*:' -g 'package.json' || true

# 3. Inventory any ESLint plugins or presets in every package.json
echo
echo "ESLint-related deps across all package.json files:"
rg -n '"eslint-' -g 'package.json' || true

Length of output: 510


Align Node engine with ESLint 9.35.0 requirement
• ESLint 9.35.0 mandates Node >= 18.18.0 (vs. current “node”: ">= 10" only in packages/gui); update your root (and any other) package.json engines to ≥ 18.18.0 or ensure CI uses a compatible Node version.

🤖 Prompt for AI Agents
In packages/core/template/config/lint/package.json around lines 7 to 9, the
project declares ESLint 9.35.0 which requires Node >= 18.18.0, but the repo
still uses "node": ">= 10" in other package.json files (e.g., packages/gui);
update the engines.node field in this package.json and any other package.json
roots (including packages/gui and the monorepo root) to ">= 18.18.0" (or a
compatible range), and ensure CI workflows and toolchain matrix are updated to
use Node 18.18.0+ so the ESLint requirement is satisfied.

@FliPPeDround FliPPeDround merged commit 41e7bb4 into main Sep 8, 2025
38 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants