-
-
Notifications
You must be signed in to change notification settings - Fork 20
chore: update deps #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update deps #125
Conversation
WalkthroughBumps devDependency versions in three template package.json files: @skiyee/ui-preset (^0.0.7→^0.0.8), eslint (^9.34.0→^9.35.0), and @types/node (^24.3.0→^24.3.1). No other fields changed and no code or API surface modifications are introduced. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/core/template/config/typescript/package.json (1)
6-10: Align @types/node in template to match root Node LTS
packages/core/template/config/typescript/package.json: change"@types/node": "^24.3.1"→"@types/node": "^18.19.50"to match the root devDependency and reduce API drift.packages/core/template/UI/skiyee/package.json (1)
6-8: Approve preset bump; evaluate template version strategy
- Semver ^0.0.8 only pulls patch updates (effectively ~0.0.8)
- All templates consistently declare
packageManager: "pnpm@9.9.0"For reproducible scaffolds, pin exact versions; keep the caret if you prefer automatic patch upgrades.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/core/template/UI/skiyee/package.json(1 hunks)packages/core/template/config/lint/package.json(1 hunks)packages/core/template/config/typescript/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: stable - aarch64-pc-windows-msvc - node@20
- GitHub Check: stable - i686-pc-windows-msvc - node@20
- GitHub Check: stable - x86_64-pc-windows-msvc - node@20
| "@uni-helper/eslint-config": "^0.5.0", | ||
| "eslint": "^9.34.0" | ||
| "eslint": "^9.35.0" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
ESLint bump looks fine; verify peer/engine compatibility.
Since you’re already on ESLint 9.x, 9.35.0 should be safe. Please double-check Node engine constraints and the eslint-config’s peerDeps to avoid hidden CI breaks.
Run:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# ESLint engine requirements
npm view eslint@9.35.0 engines
# Peer deps of your config
npm view @uni-helper/eslint-config@latest peerDependencies
# Inventory any eslint-* plugins in repo (to spot potential 9.x incompatibilities)
fd -a package.json | xargs -I{} jq -r '.devDependencies // {} | keys[]' {} | rg -n '^eslint-'Length of output: 7522
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# 1. Check Node engine constraints in the root package.json
if [ -f package.json ]; then
echo "Root package.json engines:"
jq '.engines // {}' package.json
else
echo "No root package.json found"
fi
# 2. List all Node engine constraints across every package.json
echo
echo "All package.json Node engine constraints:"
rg -nP '"node"\s*:' -g 'package.json' || true
# 3. Inventory any ESLint plugins or presets in every package.json
echo
echo "ESLint-related deps across all package.json files:"
rg -n '"eslint-' -g 'package.json' || trueLength of output: 510
Align Node engine with ESLint 9.35.0 requirement
• ESLint 9.35.0 mandates Node >= 18.18.0 (vs. current “node”: ">= 10" only in packages/gui); update your root (and any other) package.json engines to ≥ 18.18.0 or ensure CI uses a compatible Node version.
🤖 Prompt for AI Agents
In packages/core/template/config/lint/package.json around lines 7 to 9, the
project declares ESLint 9.35.0 which requires Node >= 18.18.0, but the repo
still uses "node": ">= 10" in other package.json files (e.g., packages/gui);
update the engines.node field in this package.json and any other package.json
roots (including packages/gui and the monorepo root) to ">= 18.18.0" (or a
compatible range), and ensure CI workflows and toolchain matrix are updated to
use Node 18.18.0+ so the ESLint requirement is satisfied.
Update dependencies
Summary by CodeRabbit