Use ResourceHash in blob data provider#1574
Merged
Manishearth merged 6 commits intounicode-org:mainfrom Feb 2, 2022
Merged
Conversation
robertbastian
previously approved these changes
Feb 2, 2022
| return false; | ||
| } | ||
| if slice_len <= 4 + len as usize * 4 { | ||
| if slice_len < 4 + len as usize * 4 { |
Member
There was a problem hiding this comment.
I pretty much had this code yesterday but gave up when I hit the validation error.
Manishearth
force-pushed
the
resourcehash-ule
branch
from
96d37df to
dd7298a
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
Member
|
Code size info: Before #1569: After #1569: After this PR: This is great: ZeroMap2d added a little bit of code size, but the change to ResourceKeyHash more than compensates for that, bringing overall code size down from what it was before. |
sffc
approved these changes
Feb 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encountered a minor VarZeroVec bug where the debug integrity check did not handle inserting to vectors only containing empty elements. This was fixed by changing the integrity check and adding a test. I think we didn't hit this previously due to pure chance: by switching to ResourceKeyHash the vector got reordered and it happened to start with an empty push.
cc @robertbastian