Skip to content

Conversation

@mihnita
Copy link
Collaborator

@mihnita mihnita commented Feb 14, 2024

Closes #636

@mihnita mihnita requested review from aphillips and eemeli February 14, 2024 23:33
Copy link
Member

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There might be a quibble about whether we want separate open/standalone/close productions or separate / from } on standalone, but I think this is pretty darned clean.

Thanks!!

@aphillips aphillips added syntax Issues related with syntax or ABNF Action-Item Action item assigned by the WG LDML45 labels Feb 14, 2024
@mihnita
Copy link
Collaborator Author

mihnita commented Feb 15, 2024

There might be a quibble about whether we want separate open/standalone/close productions or separate / from } on standalone, but I think this is pretty darned clean.

ACK.

I thought about this, and decided to use this style to bring it closer to the json data model, where we have 3 completely separated structures for markup-open/standalone/close.

They are also not unified in the data-model/README:

type Markup = MarkupOpen | MarkupStandalone | MarkupClose;
interface MarkupOpen {
    type: "markup";
    kind: "open";
    ...
}
interface MarkupStandalone {
    type: "markup";
    kind: "standalone";
    ...
}
interface MarkupClose {
    type: "markup";
     kind: "close";
    ....
}

On the other side, in the data-model dtd they are all unified.


I would prefer the unified style.

So the readme would be more like

type Markup = MarkupOpen | MarkupStandalone | MarkupClose;
interface Markup {
    type: "markup";
    kind; // one of "open", "close", "standalone"
    ...
}

But I didn't want to include anything controversial.

@mihnita mihnita mentioned this pull request Feb 15, 2024
@mihnita
Copy link
Collaborator Author

mihnita commented Feb 15, 2024

I would also like to fix this issue: "Extra spaces in markup #650" (that I've just created)

Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall ok, but see inline simplifications.

mihnita and others added 4 commits February 15, 2024 07:52
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
@mihnita
Copy link
Collaborator Author

mihnita commented Feb 15, 2024

All feedback implemented, thank you all!
(ready for round two :-)

Co-authored-by: Eemeli Aro <eemeli@gmail.com>
@aphillips aphillips merged commit d10a06b into unicode-org:main Feb 15, 2024
eemeli added a commit to messageformat/messageformat that referenced this pull request Feb 23, 2024
@eemeli eemeli added this to the LDML 45 milestone Jul 23, 2025
XM5jDcsHTyGJtQqlCi added a commit to XM5jDcsHTyGJtQqlCi/messageformat that referenced this pull request Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Action-Item Action item assigned by the WG syntax Issues related with syntax or ABNF

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add options to close

4 participants