Skip to content

Conversation

@aphillips
Copy link
Member

Per 2024-02-26 teleconference, add a note about the value 2-digit

Per 2024-02-26 teleconference, add a note about the value `2-digit`
@aphillips aphillips added functions Issue pertains to the default function set fast-track Editorial change permitted to use fast-track merge rules LDML45 labels Feb 26, 2024
Copy link
Collaborator

@catamorphism catamorphism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had the thought that maybe it's worth noting that the reason you have to quote it isn't specific to the string "2-digit", but is because the character '-' can't appear in an unquoted literal. But it might be better to keep it brief. Leaving that up to you.

Copy link
Collaborator

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto @catamorphism's comment

@aphillips
Copy link
Member Author

maybe it's worth noting that the reason you have to quote it isn't specific to the string "2-digit", but is because the
character '-' can't appear in an unquoted literal. But it might be better to keep it brief. Leaving that up to you.

Only that's not the reason. The character - is definitely permitted in values (but not at the start except for numbers.) The reason is that you cannot start with a digit except for number-literals. Participants will note that I argued long and hard for starts-with-digit (and lost) > 1 year ago.

@eemeli eemeli linked an issue Feb 26, 2024 that may be closed by this pull request
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
@aphillips aphillips merged commit 9caacb6 into main Feb 27, 2024
@aphillips aphillips deleted the aphillips-2-digit-quoting branch February 27, 2024 04:36
@eemeli eemeli added this to the LDML 45 milestone Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Editorial change permitted to use fast-track merge rules functions Issue pertains to the default function set

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEEDBACK] The 2-digit datetime field option values need to be quoted

5 participants