Separate data model errors from syntax errors #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split out data model errors into their own file and label tests according to the error name from the spec. No new test cases are added/removed.
|
When integrating these tests into my implementation, I was surprised to find that not all the tests in |
eemeli
reviewed
Mar 7, 2024
aphillips
added
fast-track
eemeli
approved these changes
Mar 9, 2024
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
catamorphism
added a commit
to catamorphism/message-format-wg
that referenced
this pull request
Mar 11, 2024
* Separate data model errors from syntax errors Split out data model errors into their own file and label tests according to the error name from the spec. No new test cases are added/removed. * Reformat data model error test file * Update test/syntax-errors.json Co-authored-by: Eemeli Aro <eemeli@gmail.com> * Update test/README.md Co-authored-by: Eemeli Aro <eemeli@gmail.com> --------- Co-authored-by: Addison Phillips <addisonI18N@gmail.com> Co-authored-by: Eemeli Aro <eemeli@gmail.com>
catamorphism
added a commit
to catamorphism/message-format-wg
that referenced
this pull request
Mar 11, 2024
* Separate data model errors from syntax errors Split out data model errors into their own file and label tests according to the error name from the spec. No new test cases are added/removed. * Reformat data model error test file * Update test/syntax-errors.json Co-authored-by: Eemeli Aro <eemeli@gmail.com> * Update test/README.md Co-authored-by: Eemeli Aro <eemeli@gmail.com> --------- Co-authored-by: Addison Phillips <addisonI18N@gmail.com> Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out data model errors into their own file and label tests according to the error name from the spec.
No new test cases are added/removed.