Change format of test/data-model-errors.json file #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this file was not valid JSON. Added braces and updated README file accordingly.
eemeli
requested changes
Apr 3, 2024
Collaborator
eemeli
left a comment
eemeli
left a comment
There was a problem hiding this comment.
Why not do the smaller fix of changing the JSON outermost [] into {} so that it matches the README?
Previously, this file was not valid JSON. Replaced '['/']'
with '{'/'}'.
Also removed a trailing comma and corrected typo in README file.
Collaborator
Author
You're right, that's simpler. Done in 85b77f0 |
eemeli
approved these changes
Apr 3, 2024
aphillips
approved these changes
Apr 3, 2024
ZL91
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While modifying ICU4C tests to read JSON directly from the test files in this repo, I noticed that the data-model-errors.json file I'd previously contributed is not actually valid JSON.
Added braces to make it valid, and updated README file accordingly.