feat: Sandbox integration - #458
Merged
Merged
Conversation
dragosgheorghioiu
force-pushed
the
dragosg/feat/sandbox-commands
branch
from
August 19, 2026 10:59
3ba25c6 to
94b33d9
Compare
jedevc
previously approved these changes
Aug 19, 2026
dragosgheorghioiu
force-pushed
the
dragosg/feat/sandbox-commands
branch
8 times, most recently
from
August 19, 2026 13:30
fad661c to
2d8c1ea
Compare
dragosgheorghioiu
force-pushed
the
dragosg/feat/sandbox-commands
branch
from
August 21, 2026 12:58
2d8c1ea to
723ce10
Compare
craciunoiuc
requested changes
Aug 31, 2026
craciunoiuc
left a comment
craciunoiuc
left a comment
Contributor
There was a problem hiding this comment.
I left you a lot of comments which I think need to be discussed at least
They are general comments related to the whole work + refactorings
Contributor
|
you need to rebase also 😳 |
dragosgheorghioiu
force-pushed
the
dragosg/feat/sandbox-commands
branch
7 times, most recently
from
August 31, 2026 15:54
2f15550 to
462cc7d
Compare
dragosgheorghioiu
changed the base branch from
prod-staging
to
dragosg/feat/instance-plugins
August 31, 2026 15:54
dragosgheorghioiu
force-pushed
the
dragosg/feat/sandbox-commands
branch
from
August 31, 2026 16:03
462cc7d to
1fe09d5
Compare
dragosgheorghioiu
force-pushed
the
dragosg/feat/sandbox-commands
branch
from
September 1, 2026 07:12
1fe09d5 to
462cc7d
Compare
dragosgheorghioiu
force-pushed
the
dragosg/feat/sandbox-commands
branch
6 times, most recently
from
September 3, 2026 07:43
2563fde to
61abc4f
Compare
dragosgheorghioiu
force-pushed
the
dragosg/feat/sandbox-commands
branch
2 times, most recently
from
September 3, 2026 07:58
f3299fb to
99fa486
Compare
dragosgheorghioiu
force-pushed
the
dragosg/feat/sandbox-commands
branch
from
September 3, 2026 08:32
99fa486 to
2533735
Compare
Base automatically changed from
dragosg/feat/instance-plugins
to
prod-staging
September 3, 2026 09:40
jedevc
force-pushed
the
dragosg/feat/sandbox-commands
branch
from
September 3, 2026 09:40
2533735 to
ccf32af
Compare
dragosgheorghioiu
force-pushed
the
dragosg/feat/sandbox-commands
branch
3 times, most recently
from
September 3, 2026 12:05
4a85155 to
88d4739
Compare
jedevc
reviewed
Sep 3, 2026
dragosgheorghioiu
force-pushed
the
dragosg/feat/sandbox-commands
branch
from
September 3, 2026 14:55
88d4739 to
dc56d70
Compare
craciunoiuc
reviewed
Sep 3, 2026
craciunoiuc
left a comment
craciunoiuc
left a comment
Contributor
There was a problem hiding this comment.
I actually did not find anything else significant
Signed-off-by: Dragos Gheorghioiu <dragosg@unikraft.com>
Signed-off-by: Dragos Gheorghioiu <dragosg@unikraft.com>
Signed-off-by: Dragos Gheorghioiu <dragosg@unikraft.com>
dragosgheorghioiu
force-pushed
the
dragosg/feat/sandbox-commands
branch
from
September 4, 2026 07:19
b699c4c to
9e8bd97
Compare
jedevc
approved these changes
Sep 4, 2026
jedevc
left a comment
jedevc
left a comment
Member
There was a problem hiding this comment.
Reviewed-by: Justin Chadwell <justin@unikraft.com>
Approved-by: Justin Chadwell <justin@unikraft.com>
craciunoiuc
approved these changes
Sep 4, 2026
craciunoiuc
left a comment
craciunoiuc
left a comment
Contributor
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
Approved-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: TOOL-762