feat(gno): support simulated and dynamic gas pricing for tx fees - #5484
Open
aronpark1007 wants to merge 2 commits into
Open
feat(gno): support simulated and dynamic gas pricing for tx fees#5484aronpark1007 wants to merge 2 commits into
aronpark1007 wants to merge 2 commits into
Conversation
Contributor
Author
|
TODO once #5478 lands: add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simulate(dry-run the tx via.app/simulateto get the actual gas used, then price it with the fixed linear formula) anddynamic(query gno's own protocol-levelauth/gasprice, an EIP-1559-style base fee recomputed per block from actual usage).Config.gas_configselects the mode (fixed/simulate/dynamic); the legacyfeefield is still accepted for backward compatibility (deprecated, mapped tofixed).denomoverride is configured, fee construction now errors instead of silently producing a denom-less coin string.Test plan
cargo test -p gno-client: parser/pricing/denom-fallback unit tests, including regression coverage for pricing off the post-multiplier gas limit.cargo test -p voyager-transaction-plugin-gno: config deserialization (newgas_configschema, legacyfeefallback, both-set precedence, missing-both error).