Fix OpenAPI schema generation#628
Open
pederhan wants to merge 9 commits into
Open
Conversation
Collaborator
Collaborator
|
Standardised error responses to always use lower case via an Also added more specific serializers to outputs to ensure we have "typed" output that def-spectacular can work with. Overall, this makes all endpoints acceptable to drf-spectacular. We also try to provide some meta information to text endpoints via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes OpenAPI schema generation by switching from the built-in DRF OpenAPI schema generator to drf-spectacular, as outlined in #627.
By using drf-spectacular, we get the following endpoints:
/docs: Swagger UI for viewing the schema (default)./docs/redoc: ReDoc UI for viewing the schema (alternative)./docs/schema: The OpenAPI schema (YAML file) (/docskept for backwards compatibility).Since we can't assume MREG can access the internet to fetch static files for serving swagger/redoc UI pages, we include them manually via the
drf-spectacular[sidecar]extra. Because both Swagger and ReDoc static files come from the same package, including endpoints for both costs nothing extra in terms of final container image size.Issues
Using drf-spectacular highlights numerous issues with our views:
❯ uv run ./manage.py spectacular --color --file schema.yml