Skip to content

Expose subscription info to frontend#84

Merged
ChrisPenner merged 3 commits into
mainfrom
cp/subscription-info
May 29, 2025
Merged

Expose subscription info to frontend#84
ChrisPenner merged 3 commits into
mainfrom
cp/subscription-info

Conversation

@ChrisPenner
Copy link
Copy Markdown
Member

@ChrisPenner ChrisPenner commented May 28, 2025

Overview

  • Includes isPremiumProject in get-project
  • Includes planTier in /account

Test coverage

See transcripts;

Note: planTier is at the top level for both user and org in /account; though this probably doesn't matter since you can't currently access this endpoint as an org 🤷🏼

@ChrisPenner ChrisPenner requested a review from hojberg May 28, 2025 21:58
@ChrisPenner ChrisPenner marked this pull request as ready for review May 28, 2025 21:58
"organizationMemberships" .= organizationMemberships,
"orgId" .= orgId
"orgId" .= orgId,
"planTier" .= planTier
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I don't think I've considered that this might just be how we do paid orgs

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh, I don't think it is, and I'm pretty sure it's currently impossible to go down this code-path, so I just put it there for consistency sake;

If we ever actually use the /account endpoint for orgs we'll sync up on what it should look like.

@ChrisPenner ChrisPenner merged commit 321b1da into main May 29, 2025
4 checks passed
@ChrisPenner ChrisPenner deleted the cp/subscription-info branch May 29, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants