This repository was archived by the owner on Jul 19, 2022. It is now read-only.
Finder: arrowkeys, clickable areas, and sequences #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix an issue where arrow keys used for moving up and down the Finder results would move the cursor in the input (implemented this with a more compositional keyboard event API) * Ensure the names in the results of the Finder have the clickable cursor * Update the keyboard sequence delay to 3 seconds to make it more ergonomic to perform sequence shortcuts
This was
linked to
issues
Jun 8, 2021
pchiusano
approved these changes
Jun 8, 2021
Member
pchiusano
left a comment
pchiusano
left a comment
There was a problem hiding this comment.
LGTM! Fyi GitHub can't handle fixes #123, #456, #789, you have to say fixes #123, fixes #182, fixes #789. Or I just went ahead and manually linked those issues.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
results would move the cursor in the input (implemented this with a
more compositional keyboard event API)
cursor
ergonomic to perform sequence shortcuts
Fixes #142, #135, #139