Phase 5 macOS Intel: source-built ORT + arch-safe extraction [draft, stacks on #4] - #6
Closed
NestorCanales wants to merge 1 commit into
Closed
Phase 5 macOS Intel: source-built ORT + arch-safe extraction [draft, stacks on #4]#6NestorCanales wants to merge 1 commit into
NestorCanales wants to merge 1 commit into
Conversation
…extraction Adds darwin-amd64 to assets/manifest.json. The ONNX Runtime dylib is our own source build of the official v1.26.0 tag (Microsoft's mac-Intel prebuilts stopped at 1.23), cross-compiled from arm64 and published as this repo's ort-1.26.0-darwin-x64 release with a reproducible recipe in its notes; tokenizers ships an official darwin-x86_64 prebuilt. Both are archive- and member-pinned by SHA-256 like every artifact. assets_embed_darwin_arm64.go becomes assets_embed_darwin.go (localembed && darwin) — both mac arches share the dylib name, mirroring the Linux single-file pattern. New make build-darwin-amd64 target cross-builds the Intel app from an arm64 Mac. Fixes an arch-collision bug this work exposed: the runtime extraction dir was keyed only by provider/model fingerprint, so an Intel build (or a home dir migrated from an Intel Mac) left an x86_64 dylib that poisoned the arm64 build's dlopen. Extraction dirs are now namespaced <GOOS>-<GOARCH>-<fingerprint>; no shipped users affected (the scheme exists only in this unmerged PR stack). Verified on the arm64 dev Mac via Rosetta 2: integration test passes as an x86_64 binary (cosine ordering 0.140 < 0.171 < 0.288, matching arm64 and Linux); GOARCH=amd64 make assets downloads + verifies from the repo release; the full x86_64 Wails app builds, extracts to its own arch dir (coexisting with the arm64 dir), and answers an MCP search. Native arm64 build re-verified after restoring assets. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 17, 2026
Collaborator
Author
|
Consolidated into #2 (single reviewable branch per Bo's review-workflow preference) — all commits from this PR are now in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Intel-Mac support (epic Phase 5, step 3). Stacks on #4 → #3 → #2; review in order — this diff is Intel-only.
The headline artifact
Microsoft stopped publishing mac-Intel ONNX Runtime builds at 1.23, and the epic pins 1.26.0 everywhere — so per the epic's plan, we built it ourselves from the official
v1.26.0source tag (MIT), cross-compiled from the arm64 Mac. It's published as this repo'sort-1.26.0-darwin-x64release (prerelease-flagged, reproducible build recipe in the notes) and pinned by SHA-256 in the manifest like every other artifact. The dylib was validated by running the repo's integration test as an x86_64 binary under Rosetta before publishing.Changes
assets/manifest.json—darwin-amd64: our ORT release + officiallibtokenizers.darwin-x86_64prebuilt, archive- and member-pinned.assets_embed_darwin_arm64.go→assets_embed_darwin.go(localembed && darwin) — both mac arches share the dylib filename; mirrors the Linux single-file pattern from Phase 5 Linux: manifest + embed file + darwin-guarded tray [draft, stacks on #3] #4.Makefile—make build-darwin-amd64: cross-build the Intel app from an arm64 Mac.~/.agent-memory/runtime/<fingerprint>/) wasn't arch-namespaced — an Intel build (or a home dir migrated from an Intel Mac, a common real scenario) left an x86_64 dylib that poisoned the arm64 build'sdlopen. Dirs are now<GOOS>-<GOARCH>-<fingerprint>. Caught live during verification; no shipped users affected (the extraction scheme exists only in this PR stack).Verification (arm64 dev Mac + Rosetta 2)
0.140 < 0.171 < 0.288, matching arm64 and LinuxGOARCH=amd64 make assets: downloads from the repo release, both checksums verifygo test ./...+go vetgreenRemaining in Phase 5
Windows x64 (Rust tokenizer build, needs the Windows PC) + a 10-minute Linux-amd64 runtime smoke on any x64 Linux box.
🤖 Generated with Claude Code