fix(engine): index failures must be visible in the activity log - #8
Closed
NestorCanales wants to merge 1 commit into
Closed
fix(engine): index failures must be visible in the activity log#8NestorCanales wants to merge 1 commit into
NestorCanales wants to merge 1 commit into
Conversation
IndexFile errors during AddDirectory, initialScan, OnCreate and OnModify were logged only to the process stderr — invisible in the GUI, whose Log page reads the activity_log table. A user whose files failed to index got no signal at all: the Dashboard counted the file as processed and the Log showed nothing. Found during the Phase 5 Windows field test, where an embedding bug silently dropped 79 of 105 real-vault files (only tiny single-chunk files survived) and diagnosis required capturing stderr by hand. OnDelete already logged its failures via logActivity(path, "error", ...); the four indexing sites now do the same. Regression test: failing embedder → AddDirectory / OnCreate / OnModify each must produce an activity_log "error" entry. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
NestorCanales
added a commit
that referenced
this pull request
Jul 27, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 16, 2026
Collaborator
Author
|
Consolidated into #2 (single reviewable branch per Bo's review-workflow preference) — all commits from this PR are now in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When a file fails to index (extract/chunk/embed/store error), the error went only to process stderr — invisible in the GUI. The Log page reads the
activity_logtable, which got nothing; the Dashboard progress counter even advanced past the failed file. Users believe everything indexed when it didn't.Found during the Phase 5 Windows field test: an embedding bug (fixed separately, see the
fix/local-embed-token-budgetbranch) silently dropped 79 of 105 files in a real vault — zero user-visible signal; diagnosing required manually capturing stderr.Fix
OnDeletealready logged failures vialogActivity(path, "error", ...)— the four indexing sites (AddDirectory loop, initialScan loop, OnCreate, OnModify) now do the same. stderr logging unchanged (still useful for dev).Verification
errorentry — fails on the previous code, passes now.Independent of the epic PR stack — based on
main, mergeable anytime (like #5).🤖 Generated with Claude Code