fix(app): close = quit on platforms without the macOS tray - #9
Closed
NestorCanales wants to merge 1 commit into
Closed
fix(app): close = quit on platforms without the macOS tray#9NestorCanales wants to merge 1 commit into
NestorCanales wants to merge 1 commit into
Conversation
…nto) HideWindowOnClose was unconditionally true. It pairs with the macOS status-bar tray (Show/Quit menu) — but the tray is darwin-only ObjC (tray.go), so on Windows/Linux closing the window left an invisible process with no way to surface or quit it. Users relaunch, instances stack, and the zombies contend for the single-writer SQLite DB: the Phase 5 Windows field test accumulated SIX concurrent instances, which also degraded indexing. Close now quits everywhere except macOS, where the tray workflow is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
NestorCanales
added a commit
that referenced
this pull request
Jul 27, 2026
Conflict resolution: epic main.go imports gained "runtime" only (strconv moved to app.go in the epic); the merged visibility-fix regression test updated to the epic's renamed mock field (EmbedFn -> EmbedDocumentsFn). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
Consolidated into #2 (single reviewable branch per Bo's review-workflow preference) — all commits from this PR are now in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
HideWindowOnClose: truewas set for all platforms, but the tray it pairs with (Show/Quit status-bar menu) is macOS-only. On Windows/Linux, closing the window produced an invisible zombie process — no window, no tray icon, no way to quit short of Task Manager. Each relaunch stacks another instance; they contend for the single-writer SQLite DB.Observed live in the Phase 5 Windows field test: six concurrent instances accumulated over a day of normal open/close usage, degrading indexing (lock contention) and confusing every diagnostic step.
Fix
HideWindowOnClose: runtime.GOOS == "darwin"— macOS keeps its hide-to-tray workflow unchanged; everywhere else, close quits (the standard platform convention anyway).Verification
Build/vet/tests green. Behavioral test needs a Windows GUI session — verified manually during the field test cleanup (post-fix build: closing the window terminates the process).
Independent of the epic stack — based on
main, mergeable anytime.🤖 Generated with Claude Code