fix: restore main CI (Ruby 4.0 logger dep, lutaml-model main branch) - #28
Merged
Conversation
Ruby 4.0 removed logger from default gems. The rdf gem (a runtime dependency of unitsdb via lib/unitsdb/commands/check_si/si_ttl_parser.rb) requires logger at load time but does not declare it as a dependency. Without this declaration, unitsdb fails on Ruby 4.0 with: LoadError: cannot load such file -- logger (from rdf-3.3.1/lib/rdf/util/logger.rb:2) Adding logger as an explicit runtime dependency makes unitsdb usable on Ruby 4.0 without behavior change on earlier versions.
The fix/global-context-register-lookup-fallback branch was deleted upstream after merging, so bundle install on main fails with: Git error: ... Revision fix/global-context-register-lookup-fallback does not exist in the repository This change repoints the Gemfile at lutaml-model main so bundle install resolves again.
ronaldtse
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated fixes that both block CI on main:
unitsdb.gemspec: declareloggeras a runtime dependency. Ruby 4.0 removedloggerfrom default gems, andrdf(loaded bylib/unitsdb/commands/check_si/si_ttl_parser.rb) requires it without declaring it. Result on Ruby 4.0:Gemfile: repointlutaml-modelatbranch: "main". The previousfix/global-context-register-lookup-fallbackbranch was deleted upstream after merging, so everybundle installon main fails with:Why now
The Opal PR (#27) surfaced both — they're not Opal-specific. Main has been silently broken (no CI runs since April 2026) until #27 pushed the first wave of CI against current Ruby heads. Splitting these out keeps #27 focused on Opal compatibility.
Test plan
bundle exec rspec spec/unitsdb/commands/check_si_command_spec.rb-- 3 examples, 0 failures (Ruby 3.4)bundle installresolves withlutaml-modelfrommainrake / Test on Ruby 4.0 ...)