Consider model scale#11
Merged
H3idi-X merged 1 commit intounity3d-jp:dev/mainfrom Oct 15, 2021
tyfkda:feature/consider-scale
Merged
Consider model scale#11H3idi-X merged 1 commit intounity3d-jp:dev/mainfrom tyfkda:feature/consider-scale
H3idi-X merged 1 commit intounity3d-jp:dev/mainfrom
tyfkda:feature/consider-scale
Conversation
Even if the model is scaled, the size of the gizmo will not be scaled. So you can't set the collision. This change will take scale into account and fix it to work correctly.
Contributor
|
I apologize for the long wait. We have confirmed that Gizmos are correctly affected by the scale. Thank you for your cooperation. |
H3idi-X
added a commit
that referenced
this pull request
Oct 16, 2021
* Add localization and make default language to English * update package version and supported Unity version due to localization support * fixed assembly issue during build * Add conditional localization import Localization API moved in 2020.1 and 2020.2 * Mark v1.2.0-preview.0 (unlikely name) * Adjust version to 1.2.1-preview.0 Technically based off 1.2.1-preview, but package manifest originally listed 1.2.0-preview * Consider model scale (#11) Even if the model is scaled, the size of the gizmo will not be scaled. So you can't set the collision. This change will take scale into account and fix it to work correctly. * Call SpringBoneGUIStyles.ReacquireStyles() on SpringBonePivotInspector (#12) * Updated CHANGELOG.md package.json Added upm-ci * Re-added some to CHANGELOG.md. * Updated upm-ci file to check web-hook on GitHub. * updated upm-ci-SpringBone.yml * Set up tentative enviroment just to make the project can pass yamato-ci.test. * Fixed: old mac build farm in upm-ci * Added Tests.meta to avoid yamato-ci errors. * added Tests.meta to .gitattribute Co-authored-by: Hiroki Omae <hiroki@unity3d.com> Co-authored-by: riina <54872398+riina@users.noreply.github.com> Co-authored-by: tyfkda <tyfkda@gmail.com> Co-authored-by: YuukiARIA <yuuki.aria.del.viscontie@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even if the model is scaled, the size of the gizmo will not be scaled. So you can't set the collision.
This change will take scale into account and fix it to work correctly.