fix(cache): add regression test for FindNodes pointer aliasing - #24
Merged
kael-reviewer[bot] merged 2 commits intoApr 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the pointer aliasing bug in
Cache.FindNodes(issue #23).Problem
FindNodeswas unmarshaling all matching documents into the sameobjectvariable and appending that same reference to the result slice. This caused every element in the returned slice to point to the last unmarshaled document — making all matches appear identical.Fix
The
FindNodesmethod now unmarshals each matching document into a freshmap[string]interface{}variable on each iteration, ensuring each entry in the returned slice is a distinct, independently populated object.Test
Added
TestFindNodesPointerAliasingwhich:Type: "user") but distinctNamevaluesFindNodeswith the filterNamereflect.Value.Pointer()Pre-existing test failures (unrelated to this change)
TestNextObjectAcrossCacheCursors/TestNextObjectStructsAtBoundary— Bug docs: Add comprehensive critical bug report (Bugs.md) #2 (NextObject recursion)TestFile— pre-existing nil pointer panicAcceptance Criteria