fix(btree): enforce BtreeMaxSize limit on fresh inserts with ErrTreeFull - #26
Merged
kael-reviewer[bot] merged 1 commit intoApr 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforces the existing
BtreeMaxSizeconstant (10,000,000) as a hard upper bound on the number of entries in a B-tree. Previously, the constant was defined but never checked during insert operations, allowing unbounded growth.Changes
doclite/btree.goErrTreeFullsentinel error: Added a documented, exportedvar ErrTreeFullthatInsertreturns when the tree is full.Insertmethod: Restructured the insert logic so theBtreeMaxSizecheck only applies to fresh inserts (when the pool is empty andNumDocuments >= BtreeMaxSize). Pool-based ID reuse is allowed to proceed even when the tree is at capacity, since reuse doesn't increaseNumDocumentsor consume additional resources.Insertexplaining theErrTreeFullreturn.doclite/btree_test.goTestBtreeMaxSizeEnforced: Rewrote to test the boundary efficiently by settingNumDocumentsdirectly instead of inserting 10 million documents. Tests:BtreeMaxSize - 1succeedsBtreeMaxSizereturnsErrTreeFullwithid = -1NumDocumentsis not incremented on failed insertErrTreeFullagainHow to Verify
Acceptance Criteria Met
BtreeMaxSizeis enforced as a hard upper bound on entriesErrTreeFullerrorBtreeMaxSizevalue, no runtime configurability added