Fix: handle last root numChildren when NumDocuments is exact multiple of MinKeys - #6
Merged
kael-reviewer[bot] merged 1 commit intoApr 15, 2026
Conversation
This was referenced Apr 16, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
diskInitBtree(), the last root node'snumChildrenis computed as:When
NumDocumentsis an exact multiple ofMinKeys(e.g., 2 × MinKeys), thei+1 == t.NumRootscheck applies the "partial last root" adjustment to a root that is actually full. While the== 0guard setsnumChildren = MinKeys, the underlying issue is that the partial-root logic should not apply at all in this case.Fix
doclite/btree.go: Changed the condition fromi+1 == t.NumRootstoi+1 == t.NumRoots && t.NumDocuments%int64(MinKeys) != 0, so the partial-root adjustment only applies when there genuinely is a partial last root.doclite/btree_test.go: AddedTestBtreeDiskInitExactMultiplethat inserts exactly 2 ×MinKeysdocuments and verifies:Find()numChildren == MinKeysdiskInitBtree()re-initialization, all documents remain findable andnumChildrenis correctTesting