Cxx: skip __declspec() #3383
Cxx: skip __declspec() #3383
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3383 +/- ##
==========================================
- Coverage 83.21% 83.20% -0.01%
==========================================
Files 218 218
Lines 52392 52393 +1
==========================================
Hits 43596 43596
- Misses 8796 8797 +1
Continue to review full report at Codecov.
|
|
Failures unrelated to this change are reported on the ubi8 container, a platform I cannot ignore. |
Though iconv command is available, there is a case that encodings used in test cases are not available. e.g. the ubi8 container doesn't provide shift_jis encoding unless installing glibc-langpack-ja package. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Close universal-ctags#3382 Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
cxx--skip-declspec
branch
from
5fd2ae5 to
f05982e
Compare
|
The change for fixing is enough compact and self-closed. Even when @pragmaware returns and says, "I don't like this fix," we can revert this commit quickly. I don't like this change because it throws away the information found in the source code in the early stage of parsing. The change makes it impossible to use the information in the upper stages of parsing and/or to store the information in fields of tag entries. However, this is the same as |
Changelog: ========== Merge pull request #3383(universal-ctags/ctags#3383) Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Changelog: ========== Merge pull request #3383(universal-ctags/ctags#3383) Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Changelog: ========== Merge pull request #3383(universal-ctags/ctags#3383) Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
1 participant
Close #3382
Signed-off-by: Masatake YAMATO yamato@redhat.com