test(proxy): spawn bash, not sh, in signal tests#21
Merged
Conversation
/bin/sh is dash on Ubuntu CI; dash rejects 'exec -a' so the marked sleep child exits before it ever appears, failing wait_for_match on every run. The earlier poll fix (6d696e2) addressed a different symptom; this is the actual cause of the red test job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red
testjob on CI:exec -ais a bashism — /bin/sh on Ubuntu is dash, which rejects it, so the marked sleep child exits before it appears andwait_for_matchtimes out. Verified locally:dash -c 'exec -a m sleep 1'→exec: -a: not found.Test-only change; no binary impact. Green CI needed before tagging v0.4.0.