fix(knowledge): vendored dirs poison conflict detection#200
Merged
Conversation
With INT-2318's same-project parallel selection live, the KG conflict detector deferred 4/5 intrect-platform tasks as 'conflicting' — the shared modules were entirely vendored google-cloud-sdk files (a.py, run.py, api.py, read.py, ...). Two compounding causes, same family as the INT-1810 R3 trash/ false conflicts: - the scanner indexed vendored third-party trees, adding thousands of short generic filenames to the graph → SKIP_DIRS now excludes google-cloud-sdk / third_party / vendor / vendors - analyzeIssueImpact matched filenames as raw substrings of the issue text, so 1-2 char names matched everything and 'run' matched 'running' → filename matching now requires a whole-word boundary match and a minimum name length of 3 (camelCase word-split and path-segment matching unchanged) Full suite 1401 passed, lint 0, tsc clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With #199's same-project parallel selection live, the KG conflict detector deferred 4/5 intrect-platform tasks as "conflicting" — the shared modules were entirely vendored
google-cloud-sdk/files (a.py,run.py,api.py, …). Same failure family as the INT-1810 R3trash/false conflicts. (INT-2320)Two compounding causes, both fixed:
SKIP_DIRSnow excludesgoogle-cloud-sdk/third_party/vendor/vendorsanalyzeIssueImpactmatched filenames as raw substrings of issue text (1–2 char names matched everything;runmatched "running") → filename matching now requires a whole-word boundary match and a minimum length of 3 (camelCase word-split and path-segment matching unchanged)Verification
a.py/run.py-vs-"running" while keeping legitimate boundary matches (api,login)🤖 Generated with Claude Code