Align ContentControl Behavior with UWP behavior for empty children.#2020
Merged
Align ContentControl Behavior with UWP behavior for empty children.#2020
Conversation
MatFillion
reviewed
Nov 4, 2019
Contributor
|
We should build a few tests for this :) |
Contributor
Author
Incoming, trying to make relevant tests :) |
carldebilly
approved these changes
Nov 5, 2019
476b44b to
967e613
Compare
967e613 to
8049d24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When a ContentControl in the Visual Tree does not have child elements, the dataContext is displayed instead of nothing like on UWP
What is the new behavior?
Now when a ContentControl does not have content, the control will be empty.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):