Skip to content

Align ContentControl Behavior with UWP behavior for empty children.#2020

Merged
Iguins merged 3 commits intomasterfrom
dev/guen/ContentControlBehaviorAligment
Nov 6, 2019
Merged

Align ContentControl Behavior with UWP behavior for empty children.#2020
Iguins merged 3 commits intomasterfrom
dev/guen/ContentControlBehaviorAligment

Conversation

@Iguins
Copy link
Copy Markdown
Contributor

@Iguins Iguins commented Nov 4, 2019

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

When a ContentControl in the Visual Tree does not have child elements, the dataContext is displayed instead of nothing like on UWP

What is the new behavior?

Now when a ContentControl does not have content, the control will be empty.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@Iguins Iguins added platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform labels Nov 4, 2019
@Iguins Iguins self-assigned this Nov 4, 2019
@Iguins Iguins changed the title Align ContentControl Behavior with UWP on empty child Align ContentControl Behavior with UWP behavior for empty children. Nov 4, 2019
Comment thread src/Uno.UI/UI/Xaml/Controls/ContentControl/ContentControl.cs Outdated
@MatFillion
Copy link
Copy Markdown
Contributor

We should build a few tests for this :)

@Iguins
Copy link
Copy Markdown
Contributor Author

Iguins commented Nov 4, 2019

We should build a few tests for this :)

Incoming, trying to make relevant tests :)

Comment thread src/Uno.UI/UI/Xaml/Controls/ContentControl/ContentControl.cs Outdated
@Iguins Iguins force-pushed the dev/guen/ContentControlBehaviorAligment branch from 476b44b to 967e613 Compare November 6, 2019 18:53
@github-actions github-actions Bot added area/automation Categorizes an issue or PR as relevant to project automation kind/documentation labels Nov 6, 2019
@Iguins Iguins force-pushed the dev/guen/ContentControlBehaviorAligment branch from 967e613 to 8049d24 Compare November 6, 2019 19:48
@Iguins Iguins merged commit ada85a6 into master Nov 6, 2019
@Iguins Iguins deleted the dev/guen/ContentControlBehaviorAligment branch November 6, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/automation Categorizes an issue or PR as relevant to project automation platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants