Skip to content

fix(header): preserve version dropdown hover contrast#2047

Merged
elibosley merged 1 commit into
feat/consolidated-headerfrom
fix/cld-760-version-dropdown-hover
Jul 22, 2026
Merged

fix(header): preserve version dropdown hover contrast#2047
elibosley merged 1 commit into
feat/consolidated-headerfrom
fix/cld-760-version-dropdown-hover

Conversation

@elibosley

Copy link
Copy Markdown
Member

Summary

Version dropdown rows now apply matching semantic foreground and background colors on hover and keyboard focus, preserving readable contrast in White and Azure themes.

Why This Exists

The version dropdown used theme-specific hover backgrounds without explicitly setting the corresponding foreground color. In light themes, that could leave hovered text unreadable.

Resolution

Use the shared accent and accent-foreground semantic tokens for both hovered and focused version rows. This keeps the interaction state aligned with the active theme rather than relying on gray color utilities.

Reviewer Considerations

  • The change is deliberately scoped to the two copyable version rows; it does not alter the shared dropdown primitive or unrelated menus.
  • Hover and keyboard-focus states receive the same token pair for consistent pointer and keyboard contrast.

Behavior Changes

  • Hovered or focused Unraid OS and API version rows remain legible in White and Azure themes.

Implementation Summary

  • Replace fixed gray hover backgrounds with semantic accent background and foreground utility classes in the header version dropdown.

Verification

  • pnpm --dir web run pretest (passed; UI build completed with pre-existing TypeScript diagnostics in Accordion.vue)
  • pnpm --dir web exec vitest run __test__/components/HeaderOsVersion.test.ts (3 passed)
  • pnpm --dir web exec eslint src/components/Header/HeaderVersion.vue (passed)
  • pnpm --dir web exec prettier --check src/components/Header/HeaderVersion.vue (passed)
  • git diff --check (passed)

Risk

Low; the change only applies established semantic colors to existing interaction states.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a74854b9-a778-4fc8-bfdf-cbf4947b385a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cld-760-version-dropdown-hover

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@elibosley
elibosley merged commit 541b2b4 into feat/consolidated-header Jul 22, 2026
5 checks passed
@elibosley
elibosley deleted the fix/cld-760-version-dropdown-hover branch July 22, 2026 03:01
@github-actions

Copy link
Copy Markdown
Contributor

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR2047/dynamix.unraid.net.plg

@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.88%. Comparing base (8ecfcba) to head (1839b39).
⚠️ Report is 1 commits behind head on feat/consolidated-header.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           feat/consolidated-header    #2047      +/-   ##
============================================================
- Coverage                     52.90%   52.88%   -0.02%     
============================================================
  Files                          1041     1041              
  Lines                         72266    72266              
  Branches                       8328     8330       +2     
============================================================
- Hits                          38231    38217      -14     
- Misses                        33909    33923      +14     
  Partials                        126      126              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

elibosley added a commit that referenced this pull request Jul 22, 2026
## Summary
Version dropdown rows now apply matching semantic foreground and
background colors on hover and keyboard focus, preserving readable
contrast in White and Azure themes.

## Why This Exists
The version dropdown used theme-specific hover backgrounds without
explicitly setting the corresponding foreground color. In light themes,
that could leave hovered text unreadable.

## Resolution
Use the shared accent and accent-foreground semantic tokens for both
hovered and focused version rows. This keeps the interaction state
aligned with the active theme rather than relying on gray color
utilities.

## Reviewer Considerations
- The change is deliberately scoped to the two copyable version rows; it
does not alter the shared dropdown primitive or unrelated menus.
- Hover and keyboard-focus states receive the same token pair for
consistent pointer and keyboard contrast.

## Behavior Changes
- Hovered or focused Unraid OS and API version rows remain legible in
White and Azure themes.

## Implementation Summary
- Replace fixed gray hover backgrounds with semantic accent background
and foreground utility classes in the header version dropdown.

## Verification
- `pnpm --dir web run pretest` (passed; UI build completed with
pre-existing TypeScript diagnostics in `Accordion.vue`)
- `pnpm --dir web exec vitest run
__test__/components/HeaderOsVersion.test.ts` (3 passed)
- `pnpm --dir web exec eslint src/components/Header/HeaderVersion.vue`
(passed)
- `pnpm --dir web exec prettier --check
src/components/Header/HeaderVersion.vue` (passed)
- `git diff --check` (passed)

## Risk
Low; the change only applies established semantic colors to existing
interaction states.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant