Repin GLM-5-Next to the commit that merges cleanly - #205
Merged
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repin
ggml-org/llama.cpp#27754(GLM-5-Next) from629b5055tob9b8207f.Why
The nightly has failed two nights running,
34063080108(Sep 6) and33994788048(Sep 5), both inResolve tag:Nothing has published since, which now also blocks the Authenticode signing from #204 from ever reaching a release.
The error suggests reordering, but that cannot work here: I checked, and
629b5055conflicts against a bareb10825with no other pins applied at all, producing the same two files. It is a base conflict, not an ordering one.additive_merge.pywas right to refuse. Both conflicts have a non-empty merge base, meaning each side edited an existing line, which the script never resolves by design:In this instance the union is unambiguous: it is a boolean disjunction and each side added one architecture. That is a human call, not something the script should be taught to guess, so the fix belongs in the PR rather than in
additive_merge.py.What changed upstream
b9b8207f("Fix merge conflicts") merges currentmasterinto the PR branch with both conflicts resolved as the union. ggml-org#27754 has gone fromCONFLICTINGtoMERGEABLE.One detail worth recording, because it is the part that was easy to get wrong:
llama-graph.cpphas two call sites and they are not symmetric. The base carriesHY_V4at the second site only, and the PR addsGLM5NEXTat both. So only the second site takes the union; the first merges automatically and correctly ends up withGLM5NEXTand noHY_V4. PropagatingHY_V4to both to make them look consistent would have introduced behaviour the base never had.Verification
Against the resolved tree:
libllama.soandllama-commonbuild cleantest-llama-archsbuilds and exits 0Caveat, stated rather than glossed: my local replay of the full 13-pin set diverges from CI at
#25731(I hitAUTHORSand.github/workflows/*conflicts that CI does not), so I have proven this fix against the base and againstmaster, but not that the complete pin set now merges end to end. The first nightly after this merges is what settles that.Upstream CI is running on
b9b8207fnow. Worth waiting for it to go green before merging this, since the pin is only as good as that commit.