Skip to content
This repository was archived by the owner on Jul 16, 2022. It is now read-only.

Add python 3.5 and 3.6 to CI#24

Merged
untitaker merged 3 commits intountitaker:masterfrom
WhyNotHugo:master
Mar 25, 2017
Merged

Add python 3.5 and 3.6 to CI#24
untitaker merged 3 commits intountitaker:masterfrom
WhyNotHugo:master

Conversation

@WhyNotHugo
Copy link
Contributor

Fun fact: flake was set to run with python 2.7 and 3.5, but 3.5 was not in the build matrix.

Also did some simplification, since we could remove some conditionals, variable, etc.

@WhyNotHugo
Copy link
Contributor Author

Note that current master of pip has dropped support for python2.6, so it might be about time to drop that too.

@WhyNotHugo
Copy link
Contributor Author

The virtualenv needs to be in a different directory, otherwise some tests will fail on OSX. Just leaving a comment here for posterity's sake.

@untitaker
Copy link
Owner

Thanks, but in your PR TOXENV serves no purpose and I also think the stylechecks are not executed.

@WhyNotHugo
Copy link
Contributor Author

Thanks, but in your PR TOXENV serves no purpose and I also think the stylechecks are not executed.

Oops! Fixed now!

@untitaker untitaker merged commit a8c9d86 into untitaker:master Mar 25, 2017
@untitaker
Copy link
Owner

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants