This repository was archived by the owner on Jul 16, 2022. It is now read-only.
Add python 3.5 and 3.6 to CI#24
Merged
untitaker merged 3 commits intountitaker:masterfrom Mar 25, 2017
WhyNotHugo:master
Merged
Add python 3.5 and 3.6 to CI#24untitaker merged 3 commits intountitaker:masterfrom WhyNotHugo:master
untitaker merged 3 commits intountitaker:masterfrom
WhyNotHugo:master
Conversation
Contributor
Author
|
Note that current master of |
Contributor
Author
|
The virtualenv needs to be in a different directory, otherwise some tests will fail on OSX. Just leaving a comment here for posterity's sake. |
Owner
|
Thanks, but in your PR |
Contributor
Author
Oops! Fixed now! |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fun fact: flake was set to run with python 2.7 and 3.5, but 3.5 was not in the build matrix.
Also did some simplification, since we could remove some conditionals, variable, etc.