Add functionality to parse multiple prefixes#35
Merged
haarchri merged 1 commit intoupbound:mainfrom Aug 23, 2024
Merged
Conversation
This change introduces a new function `multiprefixloop` as a convenience function for splitting multiple cidr prefixes govorned by the number of bits and required offset inside each prefix. This function might be used in instances such as dividing additional VPC cidrs into subnets without requiring multiple instances of the funtion to be declared in a given composition. Additionally this contributes towards issue upbound#2 by introducing happy path unit tests for each function.
haarchri
approved these changes
Aug 23, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a new function
multiprefixloopas a convenience function for splitting multiple cidr prefixes govorned by the number of bits and required offset inside each prefix.This function might be used in instances such as dividing additional VPC cidrs into subnets without requiring multiple instances of the funtion to be declared in a given composition.
Additionally this PR:
make debugcommand referenced in the readmeDescription of your changes
Fixes #
I have:
Runmake reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
By introducing tests that contribute towards ensuring stability of the function
Additionally by validating that there is no change to execution through
crossplane beta renderusingmake debugandmake rendercommands