Skip to content

making multi arch package and added tagging to workflows#4

Merged
humoflife merged 2 commits intomainfrom
workflows
Dec 14, 2023
Merged

making multi arch package and added tagging to workflows#4
humoflife merged 2 commits intomainfrom
workflows

Conversation

@humoflife
Copy link
Copy Markdown
Collaborator

Description of your changes

making multi arch package and added tagging to workflows

Fixes #

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

make all

Comment thread Makefile Outdated

docker-build-amd64: ## Build AMD64 Docker Image
docker build . --quiet --platform=linux/amd64 --tag runtime-amd64
docker buildx build . --quiet --platform=linux/amd64 --tag runtime-amd64
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this change?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added per previous recommendation, and removed now for consistency. Thanks for the question. Much appreciated.

Copy link
Copy Markdown
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@humoflife humoflife merged commit acbeace into main Dec 14, 2023
@humoflife humoflife deleted the workflows branch December 14, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants