Promote OrderValue CellRenderer as Hypertable money type - #272
Merged
JulienVannier66 merged 2 commits intoAug 7, 2026
Conversation
JulienVannier66
requested review from
nathalieArnoux and
olxmpe
and removed request for
a team
August 5, 2026 13:01
JulienVannier66
force-pushed
the
jv/vel-8179/promote-ordervalue-cell-renderer
branch
from
August 5, 2026 13:05
e2076b3 to
9c628ab
Compare
olxmpe
approved these changes
Aug 5, 2026
| handler: TableHandler; | ||
| column: Column; | ||
| row: Row; | ||
| extra?: { [key: string]: any }; |
Contributor
Author
There was a problem hiding this comment.
Miss copy for this one, not used in amount cell renderer. I remove it, thanks
upfluence-bot
added
reviewed/needs-review
reviewed/needs-work
and removed
reviewed/ready-to-merge
reviewed/needs-review
labels
phndiaye
approved these changes
Aug 5, 2026
aprentout
approved these changes
Aug 6, 2026
JulienVannier66
deleted the
jv/vel-8179/promote-ordervalue-cell-renderer
branch
August 7, 2026 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Promote OrderValue CellRenderer in Reporting App as Hypertable money type
What are the observable changes?
🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist