Skip to content

Add destination argument to createCardTransation action method #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruipenso merged 1 commit into from
May 31, 2017
Merged

Add destination argument to createCardTransation action method #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions docs/actions/card-transaction/create-card-transaction.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,13 @@ The `commit` argument will add the `commit` query parameter.

The `body` argument accepts the following keys:

| Key | Type | Description |
|:---------------|:-------|:-------------------------------------------------------------|
| `amount` | String | The value amount to send in the denominated currency |
| `currency` | String | The currency by which you wish to denominate the transaction |
| `message` | String | Transaction details |
| `securityCode` | String | Credit card security code |
| Key | Type | Description |
|:---------------|:-------|:------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `amount` | String | The value amount to send in the denominated currency |
| `currency` | String | The currency by which you wish to denominate the transaction |
| `destination` | String | The destination of the transaction, which can be in the form of a bitcoin address, an email address, an account id, an application id or an Uphold username |
| `message` | String | Transaction details |
| `securityCode` | String | Credit card security code |

This method returns a **Promise**.

Expand Down
3 changes: 2 additions & 1 deletion src/core/actions/card-transaction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,14 @@ export function commitCardTransaction(cardId, transactionId, { message, security
}

// eslint-disable-next-line max-params
export function createCardTransaction(cardId, { amount, currency, message, securityCode }, commit, otp, options) {
export function createCardTransaction(cardId, { amount, currency, destination, message, securityCode }, commit, otp, options) {
options = merge({
body: {
denomination: {
amount,
currency
},
destination,
message,
securityCode
},
Expand Down
6 changes: 4 additions & 2 deletions test/core/actions/card-transaction.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ describe('CardTransactionActions', () => {

describe('createCardTransaction()', () => {
it('should make a request to `POST /me/cards/:cardId/transactions`', () => {
return sdk.createCardTransaction('bar', { amount: 'biz', currency: 'baz', message: 'buz', securityCode: 'bez' }, false, false, { qux: 'qix' })
return sdk.createCardTransaction('bar', { amount: 'biz', currency: 'baz', destination: 'qax', message: 'buz', securityCode: 'bez' }, false, false, { qux: 'qix' })
.then(result => {
expect(result).toBe('foo');
expect(sdk.api).toBeCalledWith('/me/cards/bar/transactions', {
Expand All @@ -64,6 +64,7 @@ describe('CardTransactionActions', () => {
amount: 'biz',
currency: 'baz'
},
destination: 'qax',
message: 'buz',
securityCode: 'bez'
},
Expand All @@ -74,7 +75,7 @@ describe('CardTransactionActions', () => {
});

it('should make a request to `POST /me/cards/:cardId/transactions` with commit query paramameter', () => {
return sdk.createCardTransaction('bar', { amount: 'biz', currency: 'baz', message: 'buz', securityCode: 'bez' }, true, false, { queryParams: { qux: 'qix' } })
return sdk.createCardTransaction('bar', { amount: 'biz', currency: 'baz', destination: 'qax', message: 'buz', securityCode: 'bez' }, true, false, { queryParams: { qux: 'qix' } })
.then(result => {
expect(result).toBe('foo');
expect(sdk.api).toBeCalledWith('/me/cards/bar/transactions', {
Expand All @@ -83,6 +84,7 @@ describe('CardTransactionActions', () => {
amount: 'biz',
currency: 'baz'
},
destination: 'qax',
message: 'buz',
securityCode: 'bez'
},
Expand Down