Skip to content

🐛 Support Unicode site names in graphs - #267

Merged
AnandChowdhary merged 1 commit into
masterfrom
fix/upptime-maintenance-20260625
Jun 25, 2026
Merged

🐛 Support Unicode site names in graphs#267
AnandChowdhary merged 1 commit into
masterfrom
fix/upptime-maintenance-20260625

Conversation

@AnandChowdhary

Copy link
Copy Markdown
Member

Summary

  • Adds shared slug resolution for graph generation: explicit site.slug → ASCII slugified name → sanitized Unicode site name → URL fallback.
  • Preserves non-ASCII site names such as 鸭鸭梨 when ASCII slugification returns an empty value.
  • Adds a regression test covering graph generation for a pure CJK site name.

Fixes upptime/upptime#933

Test plan

  • PATH=/tmp/node-v14.21.3-linux-x64/bin:$PATH npm ci
  • PATH=/tmp/node-v14.21.3-linux-x64/bin:$PATH npm test -- --runInBand src/index.spec.ts
  • PATH=/tmp/node-v14.21.3-linux-x64/bin:$PATH npm run build
  • PATH=/tmp/node-v14.21.3-linux-x64/bin:$PATH npm test
  • PATH=/tmp/node-v14.21.3-linux-x64/bin:$PATH npm pack --dry-run

Notes

  • This follows the Unicode slug fallback pattern already used by upptime/uptime-monitor.
  • Local validation used Node 14 to match the legacy canvas/chartjs dependency stack.

@AnandChowdhary
AnandChowdhary merged commit 61226bf into master Jun 25, 2026
7 checks passed
@AnandChowdhary
AnandChowdhary deleted the fix/upptime-maintenance-20260625 branch June 25, 2026 09:13
@upptime upptime locked and limited conversation to collaborators Jun 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Result error when chinese site name been set

2 participants