Derive COMM segment for MCX futures search and default exact-match off - #159
Merged
Conversation
upstox-security-review
approved these changes
Aug 5, 2026
elninad
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the Search Futures page of the Streamlit interactive examples, searching for MCX commodities
(e.g. CRUDE) returned "No futures found", even though the equivalent API call works:
curl --location
'https://api.upstox.com/v2/instruments/search?query=CRUDE&exchanges=MCX&segments=FUT'
--header 'Accept: application/json'
--header 'Authorization: Bearer <YOUR_ACCESS_TOKEN>'
Root cause
get_futures_sorted() defaulted to segment="FO". The Search Futures and Futures OI Buildup pages
both offer MCX in the exchange dropdown but never passed a segment, so MCX searches ran against FO
and returned nothing. MCX commodities live under the COMM segment.
Changes
when not passed explicitly: MCX → COMM, otherwise FO. Explicit segment values (e.g. CURR, COMM)
are still honored, so existing callers are unaffected. This fixes both affected pages (Search
Futures and Futures OI Buildup) at the source rather than per call site.
page now defaults to False, so partial queries like CRUDE return CRUDEOIL contracts instead of
being filtered out.
Testing