Merged
Conversation
Fixes erroring out when there are empty directories under uptick-cluster/apps
|
|
||
| def is_valid_app_directory(directory: PosixPath) -> bool: | ||
| files = ["deployment.yml", "secrets.yml"] | ||
| files_exist = False |
Collaborator
There was a problem hiding this comment.
can simplify this greatly with any() and a list comprehension.
Contributor
Author
There was a problem hiding this comment.
can we work with only one file ? or do we have to have both files for working app directory ?
uptickmetachu
approved these changes
Dec 10, 2023
Collaborator
uptickmetachu
left a comment
uptickmetachu
left a comment
There was a problem hiding this comment.
Conditional approval; there are a few more places you'll need to bump.
CTRL+F for 0.9.21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes erroring out when there are empty directories under uptick-cluster/apps