Extend smooth_method="secondary_cox" with 3-knot Restricted Cubic Splines - #308
Conversation
…ines Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
…ines Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
…ines and bump version to 0.1.33 Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
1 participant
Extended smooth_method="secondary_cox" in create_calibration_curve_times to fit secondary Cox proportional hazards models using 3-knot restricted cubic splines (RCS) on complementary log-log transformed predictions, matching McLernon et al. (2023) and Harrell's rms::val.surv. Added basis calculation, docstring updates, and unit tests.
PR created automatically by Jules for task 689652327460765094 started by @uriahf