Skip to content

Validate probability and outcome domains - #341

Merged
uriahf merged 4 commits into
mainfrom
fix/input-domain-validation
Aug 20, 2026
Merged

Validate probability and outcome domains#341
uriahf merged 4 commits into
mainfrom
fix/input-domain-validation

Conversation

@uriahf

@uriahf uriahf commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • reject probabilities outside [0, 1] before binary or time-dependent binning
  • reject binary outcomes outside {0, 1}
  • reject time-dependent event codes outside {0, 1, 2}
  • add focused regression tests for both binary and *_times paths

R parity

The R package explicitly validates probability ranges and binary outcome codes before calculation. This brings the Python performance-data APIs in line with that contract and gives the time-dependent path an equivalent event-code check.

Audit classification

Input-validation / correctness issue: invalid values could reach NumPy/Polars binning or mapping internals and fail inconsistently or misleadingly.

No valid-input calculations, cutoff semantics, estimators, plotting behavior, or dependencies are changed.

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-20 12:11 UTC

@uriahf
uriahf marked this pull request as ready for review August 20, 2026 12:11
@uriahf
uriahf merged commit f1936a4 into main Aug 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant