Skip to content

Clear ty baseline and enforce type checking - #348

Merged
uriahf merged 7 commits into
mainfrom
modernize/ty-clean-baseline
Aug 20, 2026
Merged

Clear ty baseline and enforce type checking#348
uriahf merged 7 commits into
mainfrom
modernize/ty-clean-baseline

Conversation

@uriahf

@uriahf uriahf commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • resolve all 11 ty diagnostics identified in Probe ty readiness in CI #347
  • keep the fixes behavior-preserving and focused on annotations/narrowing
  • make uv run ty check src/rtichoke blocking in package CI

What changed

  • make intentional calibration function rebinding explicit via setattr
  • narrow normalized time mappings for ty
  • accept NumPy arrays in strata-formatting annotations
  • narrow Polars scalar maxima before float conversion
  • isolate the Reactable callable/stub mismatch with a narrow cast

Validation

  • uv run ty check src/rtichoke — passes with zero diagnostics
  • uv run ruff check . — passes
  • uv run ruff format --check . — passes
  • uv build — passes
  • uv run pytest tests — 137 passed

Scope

Typing and developer tooling only. No runtime dependencies, public API changes, statistical changes, or intentional behavior changes.

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-20 19:10 UTC

@uriahf
uriahf marked this pull request as ready for review August 20, 2026 19:08
@uriahf
uriahf merged commit 58ded6b into main Aug 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant