Skip to content

removing unecessary boolean parsing in check.py#21

Merged
vsoch merged 1 commit intomasterfrom
revert/back-to-working-client
Apr 5, 2020
Merged

removing unecessary boolean parsing in check.py#21
vsoch merged 1 commit intomasterfrom
revert/back-to-working-client

Conversation

@vsoch
Copy link
Copy Markdown
Collaborator

@vsoch vsoch commented Apr 5, 2020

This is the final fix to revert back to the working version - a boolean argument going into this function does not need special parsing as a string.

Signed-off-by: vsoch vsochat@stanford.edu

Signed-off-by: vsoch <vsochat@stanford.edu>
Copy link
Copy Markdown
Member

@SuperKogito SuperKogito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is probably the extent of it.
I made other small changes but they were just to fix the pattern whitelisting.

@vsoch
Copy link
Copy Markdown
Collaborator Author

vsoch commented Apr 5, 2020

I deleted the latest and master tag on quay.io, and strangely the tag for 0.0.14 was missing so I think the CI is broken too. I originally had it releasing a latest and a tag for the version so something is up.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 5, 2020

Codecov Report

Merging #21 into master will increase coverage by 1.34%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   70.73%   72.07%   +1.34%     
==========================================
  Files          15       15              
  Lines         516      505      -11     
==========================================
- Hits          365      364       -1     
+ Misses        151      141      -10     
Impacted Files Coverage Δ
urlchecker/client/check.py 24.59% <0.00%> (+2.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a97a8...3f98f0b. Read the comment docs.

@vsoch
Copy link
Copy Markdown
Collaborator Author

vsoch commented Apr 5, 2020

@SuperKogito what does codecov have an issue with?

@vsoch
Copy link
Copy Markdown
Collaborator Author

vsoch commented Apr 5, 2020

I'm going to ignore it then, doesn't seem logical.

@vsoch vsoch merged commit f166ffb into master Apr 5, 2020
@vsoch vsoch deleted the revert/back-to-working-client branch April 5, 2020 16:31
@SuperKogito
Copy link
Copy Markdown
Member

just ignore it. We will come back to that later. I am very sorry for this mess :( This was not the way I wanted to come back :/

@vsoch
Copy link
Copy Markdown
Collaborator Author

vsoch commented Apr 5, 2020

The container build for some reason is also broken - it just released 0.0.13 again, which seems to be the broken version.

@SuperKogito
Copy link
Copy Markdown
Member

Could it be because I automated the builds? :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants