removing unecessary boolean parsing in check.py#21
Conversation
Signed-off-by: vsoch <vsochat@stanford.edu>
SuperKogito
left a comment
There was a problem hiding this comment.
Yeah this is probably the extent of it.
I made other small changes but they were just to fix the pattern whitelisting.
|
I deleted the latest and master tag on quay.io, and strangely the tag for 0.0.14 was missing so I think the CI is broken too. I originally had it releasing a latest and a tag for the version so something is up. |
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 70.73% 72.07% +1.34%
==========================================
Files 15 15
Lines 516 505 -11
==========================================
- Hits 365 364 -1
+ Misses 151 141 -10
Continue to review full report at Codecov.
|
|
@SuperKogito what does codecov have an issue with? |
|
I'm going to ignore it then, doesn't seem logical. |
|
just ignore it. We will come back to that later. I am very sorry for this mess :( This was not the way I wanted to come back :/ |
|
The container build for some reason is also broken - it just released 0.0.13 again, which seems to be the broken version. |
|
Could it be because I automated the builds? :/ |
This is the final fix to revert back to the working version - a boolean argument going into this function does not need special parsing as a string.
Signed-off-by: vsoch vsochat@stanford.edu